GTK build with dotnet6+xbuild #220
Conversation
knocte
changed the title
aarani
force-pushed
the
wip/byeKzu
branch
7 times, most recently
from
3407e87
to
e15b622
Compare
|
CI is red, please retry builds if needed. |
aarani
force-pushed
the
wip/byeKzu
branch
3 times, most recently
from
f8aa7ef
to
f24c531
Compare
Typo: exist -> exists |
|
CI is red. |
This commit msg has the what but not the why (btw, considering that this fixes a problem introduced in the previous commit, maybe you should just squash it with previous, but please don't forget to add the why in commit msg) |
We renamed the project long time ago so it is about time to follow suit with the solution file name.
This way they don't get confused with the main solution (and still can be used by make.fsx to build with the command line).
Updating links to scripts and Fsdk in main solution, and deleting them on the others (since the others will only be used for building now, not for using in the IDE).
This commit msg is confusing. I guess you meant to write "dotnet", but later decided to shorten it to be able to meet the 50char, however shortening "dotnet" to ".NET" makes it confusing because .NET could mean .NETFramework or .NETCore/.NET6. |
Missing the why (I guess the best way to address this is maybe squash this commit with previous, because it's the previous one the one that contains the purpose). |
Missing the why. |
This allows for building Backend and Frontend.XF with separate build engine like .NET 6.
This commit allows for using legacy and non-legacy build tools together to build GTK frontend without using MS's binaries (newmono-msbuild). It works by building .NETStandard project (that xbuild can't build) using .NET6 and building GTK project using xbuild. Co-authored-by: Afshin Arani <[email protected]>
Now that we removed [1] NuGet.Restore.targets, and NuGet.exe gets downloaded by Fsdk via WebClient, I don't think we need curl anymore. [1] 04277ed
No, not only this. The previous commits did. You could mention their commit hashes.
And why do this again? |
Previous commit was for just Backend, these are for the other two projects. |
This commit alongside [1] allow for building GTK front- end on this lane. [1] 7f6c88d
That's not answering my question :) |
Because there were build errors and I had to? :\ |
|
You know, the result of the configue.sh/configure.bat status includes now the Frontend type in it, but it's referring to the default frontend (the one run when using 'make run'). But the commit "scripts/make: build frontend when dotnet exists" should probably change this to show "Frontend: Console (default) & XamarinForms" but only on macOS, which is the only platform where both frontends are built and the default is not XF. |
And why is that REAL REASON not included in the commit msg? |
aarani
force-pushed
the
wip/byeKzu
branch
2 times, most recently
from
3fb9533
to
3d01853
Compare
Before this commit, we were assuming that legacy tools were not present if dotnet was present. Now, if dotnet is present, and legacy tools also are (so that the XF frontend can be built), then make will build the frontend. Obj path in some projects had to be changed like it was done in [1] because building same project once with dotnet and once with MSBuild causes problems (it happens in macOS when both mono and dotnet exist). [1] 6b3c64e
.github/workflows/CI.yml
Outdated
|
|
||
| run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make dotnet6 mono-xbuild fsharp | ||
| - name: install GTK libs (dependency of GTK frontend) | ||
| run: sudo apt install -y libgtk2.0-cil-dev |
There was a problem hiding this comment.
we should use --yes here, not -y
There have been some recent cosmetic commits so it's better to group them here to avoid git-blame pollution.
No description provided.